Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.9.1 #34617

Merged
merged 2 commits into from
Sep 6, 2024
Merged

2024.9.1 #34617

merged 2 commits into from
Sep 6, 2024

Conversation

balloob
Copy link
Member

@balloob balloob commented Sep 6, 2024

Proposed change

Release notes for home-assistant/core#125420

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

  • Link to parent pull request in the codebase:
  • Link to parent pull request in the Brands repository:
  • This PR fixes or closes issue: fixes #

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

Summary by CodeRabbit

  • New Features

    • Introduced a "Patch releases" section detailing weekly updates focused on bug fixes.
    • Added a section for "Release 2024.9.1 - September 6," highlighting specific fixes and improvements to various integrations.
  • Bug Fixes

    • Included enhancements for integrations such as BTHome, LinkPlay, and Yale Smart Alarm.
  • Documentation

    • Updated versioning information and release date in the configuration file for better user clarity.

@home-assistant
Copy link

home-assistant bot commented Sep 6, 2024

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Sep 6, 2024
Copy link
Contributor

coderabbitai bot commented Sep 6, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

Walkthrough

The updates made involve changes to the _config.yml file and the source/_posts/2024-09-04-release-20249.markdown file. The _config.yml file reflects an increment in the current_patch_version and an updated date_released. The markdown file introduces a new "Patch releases" section and details specific fixes and improvements in the latest release, enhancing documentation clarity regarding ongoing updates.

Changes

Files Change Summary
_config.yml Updated current_patch_version from 0 to 1 and date_released from 2024-09-04 to 2024-09-06.
source/_posts/2024-09-04-release-20249.markdown Added "Patch releases" section and "Release 2024.9.1 - September 6" section detailing specific fixes and improvements, including contributor references and pull request numbers.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit e4fa05b
🔍 Latest deploy log https://app.netlify.com/sites/home-assistant-docs/deploys/66db446c37a5e100085e1737
😎 Deploy Preview https://deploy-preview-34617--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

- Update frontend to 20240906.0 ([@piitaya] - [#125409]) ([frontend docs])
- Bump pyatv to 0.15.1 ([@postlund] - [#125412]) ([apple_tv docs])

[#123544]: https://github.com/home-assistant/core/pull/123544
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unused link and image reference definitions.

Several link and image reference definitions are unused throughout the document, which can lead to confusion and clutter. Removing these unused references will clean up the document and ensure that all links and references are necessary and functional.

Apply this diff to remove the unused references:

- [#123544]: https://github.com/home-assistant/core/pull/123544
- [#124069]: https://github.com/home-assistant/core/pull/124069
- [#124569]: https://github.com/home-assistant/core/pull/124569
- [#124880]: https://github.com/home-assistant/core/pull/124880
- [@balloob]: https://github.com/balloob
- [@edenhaus]: https://github.com/edenhaus
- [@frenck]: https://github.com/frenck
- [@joostlek]: https://github.com/joostlek
- [@tl-sl]: https://github.com/tl-sl
- [apsystems docs]: /integrations/apsystems/

Also applies to: 256-256, 258-258, 259-259, 282-282, 286-286, 288-288, 290-290, 298-298, 301-301

Tools
Markdownlint

255-255: Unused link or image reference definition: "#123544"
Link and image reference definitions should be needed

(MD053, link-image-reference-definitions)

[yale_smart_alarm docs]: /integrations/yale_smart_alarm/
[yamaha docs]: /integrations/yamaha/


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unnecessary blank lines.

There are multiple consecutive blank lines at the end of the document. According to Markdownlint rule MD012, this should be reduced to a single blank line to maintain consistency and cleanliness in the document structure.

Apply this diff to fix the issue:

- 
- 
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
Tools
Markdownlint

317-317: Expected: 1; Actual: 2
Multiple consecutive blank lines

(MD012, no-multiple-blanks)

@home-assistant
Copy link

home-assistant bot commented Sep 6, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft September 6, 2024 15:07
@balloob balloob marked this pull request as ready for review September 6, 2024 18:08
@home-assistant home-assistant bot requested a review from joostlek September 6, 2024 18:08
@balloob balloob merged commit 89699c5 into current Sep 6, 2024
8 checks passed
@balloob balloob deleted the 2024.9.1 branch September 6, 2024 18:08
@home-assistant home-assistant bot added in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch and removed needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch in-progress This PR/Issue is currently being worked on labels Sep 6, 2024
@home-assistant
Copy link

home-assistant bot commented Sep 6, 2024

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
current This PR goes into the current branch has-parent This PR has a parent PR in a other repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants