-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024.9.1 #34617
Conversation
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
Caution Review failedThe pull request is closed. WalkthroughWalkthroughThe updates made involve changes to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
- Update frontend to 20240906.0 ([@piitaya] - [#125409]) ([frontend docs]) | ||
- Bump pyatv to 0.15.1 ([@postlund] - [#125412]) ([apple_tv docs]) | ||
|
||
[#123544]: https://github.com/home-assistant/core/pull/123544 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unused link and image reference definitions.
Several link and image reference definitions are unused throughout the document, which can lead to confusion and clutter. Removing these unused references will clean up the document and ensure that all links and references are necessary and functional.
Apply this diff to remove the unused references:
- [#123544]: https://github.com/home-assistant/core/pull/123544
- [#124069]: https://github.com/home-assistant/core/pull/124069
- [#124569]: https://github.com/home-assistant/core/pull/124569
- [#124880]: https://github.com/home-assistant/core/pull/124880
- [@balloob]: https://github.com/balloob
- [@edenhaus]: https://github.com/edenhaus
- [@frenck]: https://github.com/frenck
- [@joostlek]: https://github.com/joostlek
- [@tl-sl]: https://github.com/tl-sl
- [apsystems docs]: /integrations/apsystems/
Also applies to: 256-256, 258-258, 259-259, 282-282, 286-286, 288-288, 290-290, 298-298, 301-301
Tools
Markdownlint
255-255: Unused link or image reference definition: "#123544"
Link and image reference definitions should be needed(MD053, link-image-reference-definitions)
[yale_smart_alarm docs]: /integrations/yale_smart_alarm/ | ||
[yamaha docs]: /integrations/yamaha/ | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove unnecessary blank lines.
There are multiple consecutive blank lines at the end of the document. According to Markdownlint rule MD012, this should be reduced to a single blank line to maintain consistency and cleanliness in the document structure.
Apply this diff to fix the issue:
-
-
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Tools
Markdownlint
317-317: Expected: 1; Actual: 2
Multiple consecutive blank lines(MD012, no-multiple-blanks)
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Joost Lekkerkerker <[email protected]>
It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the |
Proposed change
Release notes for home-assistant/core#125420
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit
New Features
Bug Fixes
Documentation